Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for zombie invalid and penalized txs #7659

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Sep 20, 2024

PR description

Fix to avoid that a pending tx that is found to be invalid and it is also penalized at the same time, could be removed from the pool and re-added as a zombie in the sorted list

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the fix-removing-invalid-penalized-tx branch from d2a356e to 14686c6 Compare September 23, 2024 08:43
@fab-10 fab-10 marked this pull request as ready for review September 23, 2024 09:06
@macfarla macfarla enabled auto-merge (squash) September 30, 2024 05:24
@macfarla macfarla merged commit ffef4d5 into hyperledger:main Sep 30, 2024
43 checks passed
@fab-10 fab-10 deleted the fix-removing-invalid-penalized-tx branch November 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants